Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification

[Andreas Färber]

Am 28.03.2012 15:46, schrieb Max Filippov:
>>> +static void arm_cpu_reset(CPUState *c)
>>> +{
>>> +    ARMCPU *cpu = ARM_CPU(c);
>>> +    ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu);
>>> +
>>> +    class->parent_reset(c);
>>
>> I thought we were avoiding 'class' in favour of 'klass'?
> 
> I have suggested it once and I can only say it again,
> please, call it 'cpu_class'. It is the least surprising name.

No, cpu_class is being used for a different class, CPUClass, when
twiddling with reset handlers of the parent class, for instance.

We could call it arm_cpu_class, but is that any better?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg