Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules

[Stefan Hajnoczi]

On Tue, Mar 27, 2012 at 09:49:12PM +0200, Lluís Vilanova wrote:
> A full rewrite of the tracetool script using per-format and per-backend 
> modules,
> so that it's easier to read and extend it in the future.
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> NOTE: This series applies in current master, ignoring the "Rewrite tracetool
>       using python" series.
> 
> Changes in v3:
> 
> * Some minor fixes according to comments from Alon Levy:
> ** Fixed some rogue tabs.
> ** Fixed definition of '_SCRIPT' in "tracetool.py".
> ** Fixed some documentation.
> ** Defensively treat results from 'try_import' in 'get_list'.
> ** Fixed the no-arguments case in 'tracetool.backend.dtrace.d'.
> ** Fixed the commandline checks for the "stap" format.
> ** Added '__repr__' methods for both Event and Arguments objects.
> 
> 
> Changes in v2:
> 
> * Fixed a strange import error.
> * Add a pointer to 'tracetool.out' in the format and backend documentation.
> 
> Lluís Vilanova (8):
>       tracetool: Rewrite infrastructure as python modules
>       tracetool: Add module for the 'c' format
>       tracetool: Add module for the 'h' format
>       tracetool: Add support for the 'stderr' backend
>       tracetool: Add support for the 'simple' backend
>       tracetool: Add support for the 'ust' backend
>       tracetool: Add support for the 'dtrace' backend
>       tracetool: Add MAINTAINERS info
> 
> 
>  MAINTAINERS                           |    2 
>  Makefile.objs                         |    6 
>  Makefile.target                       |   13 -
>  configure                             |    4 
>  scripts/tracetool                     |  648 
> ---------------------------------
>  scripts/tracetool.py                  |  141 +++++++
>  scripts/tracetool/__init__.py         |  223 +++++++++++
>  scripts/tracetool/backend/__init__.py |  119 ++++++
>  scripts/tracetool/backend/dtrace.py   |  104 +++++
>  scripts/tracetool/backend/simple.py   |   60 +++
>  scripts/tracetool/backend/stderr.py   |   61 +++
>  scripts/tracetool/backend/ust.py      |  102 +++++
>  scripts/tracetool/format/__init__.py  |   96 +++++
>  scripts/tracetool/format/c.py         |   20 +
>  scripts/tracetool/format/d.py         |   20 +
>  scripts/tracetool/format/h.py         |   45 ++
>  scripts/tracetool/format/stap.py      |   20 +
>  17 files changed, 1025 insertions(+), 659 deletions(-)
>  delete mode 100755 scripts/tracetool
>  create mode 100755 scripts/tracetool.py
>  create mode 100644 scripts/tracetool/__init__.py
>  create mode 100644 scripts/tracetool/backend/__init__.py
>  create mode 100644 scripts/tracetool/backend/dtrace.py
>  create mode 100644 scripts/tracetool/backend/simple.py
>  create mode 100644 scripts/tracetool/backend/stderr.py
>  create mode 100644 scripts/tracetool/backend/ust.py
>  create mode 100644 scripts/tracetool/format/__init__.py
>  create mode 100644 scripts/tracetool/format/c.py
>  create mode 100644 scripts/tracetool/format/d.py
>  create mode 100644 scripts/tracetool/format/h.py
>  create mode 100644 scripts/tracetool/format/stap.py

Only one point: please don't introduce PUBLIC yet.  Let's add it when
it's needed.  At the moment nothing uses it.

I have tested this series with all backends and looked at the diff
between the old tracetool and tracetool.py.

I'm happy with this series.  We need to test it hard for 1.1 to make
sure there are no hickups for tracing users.

Stefan