qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt
Date: Fri, 30 Mar 2012 10:09:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120307 Thunderbird/10.0.3

On 03/29/12 22:56, Alon Levy wrote:
> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail.

Nice start (there are more guest-triggerable asserts to be fixed this way).

> qxl_phys2virt requires an additional argument because all it's possible
> return values are legit (well, I could use the fact it returns a pointer
> so it should be word aligned but I don't want to go there, this is
> totally internal).

Really?  What is bad with returning and checking for NULL?  Guest
memslots are backed by guest ram and should never ever resolve to a NULL
pointer in qemu's process address space.

cheers,
  Gerd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]