Re: [Qemu-devel] [PATCH 2/2] qapi: convert device_del

[Luiz Capitulino]

On Thu, 29 Mar 2012 11:55:31 -0600
Eric Blake <address@hidden> wrote:

> On 03/29/2012 10:56 AM, Luiz Capitulino wrote:
> > Signed-off-by: Anthony Liguori <address@hidden>
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> >  hmp-commands.hx   |    3 +--
> >  hmp.c             |    9 +++++++++
> >  hmp.h             |    1 +
> >  hw/qdev-monitor.c |   18 +++++-------------
> >  qapi-schema.json  |   20 ++++++++++++++++++++
> >  qmp-commands.hx   |    5 +----
> >  6 files changed, 37 insertions(+), 19 deletions(-)
> 
> > +# @device_del:
> > +#
> > +# Remove a device from a guest
> > +#
> > +# @id: the name of the device
> > +#
> > +# Returns: Nothing on success
> > +#          If @id is not a valid device, DeviceNotFound
> > +#          If the device does not support unplug, BusNoHotplug
> > +#
> > +# Notes: When this command completes, the device may not be removed from 
> > the
> > +#        guest.  Hot removal is an operation that requires guest 
> > cooperation.
> > +#        This command merely requests that the guest begin the hot removal
> > +#        process.
> 
> Nothing against your patch itself, but is there any way we could enhance
> things in future patches to actually notify the management app when the
> guest has cooperated and the devices is actually removed?  A new event
> would be helpful, as well as a way to detect whether the new event
> exists and should be waited for.

To allow to query for the existence of the event, we need to add the
'event' type to the qapi and allow clients to query our schema. Maybe we
could try it for 1.2.

The 'device removed' event could be added now, but I think it's better to
wait for the QOM refactoring because there might be better ways to do it.