qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] use: fix bit test


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] use: fix bit test
Date: Mon, 02 Apr 2012 11:50:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0

Am 02.04.2012 08:35, schrieb Lai Jiangshan:
> 
> use & instead of the wrong &&
> 
> Signed-off-by: Lai Jiangshan <address@hidden>

Patch looks okay but the subject should probably be fixed to say "usb:"
when applying. :)

Andreas

> ---
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 73b0c7f..89c2406 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
>      int level = 0;
>  
>      if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
> -        xhci->usbcmd && USBCMD_INTE) {
> +        xhci->usbcmd & USBCMD_INTE) {
>          level = 1;
>      }
>  

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]