Re: [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support

[Peter Maydell]

On 2 April 2012 11:50, Daniel P. Berrange <address@hidden> wrote:
> diff --git a/configure b/configure
> index cd40d17..64ab4dc 100755
> --- a/configure
> +++ b/configure
> @@ -1168,11 +1168,13 @@ gcc_flags="$gcc_flags -Wendif-labels"
>  cat > $TMPC << EOF
>  int main(void) { return 0; }
>  EOF
> +warning_flags=
>  for flag in $gcc_flags; do
> -    if compile_prog "-Werror $flag" "" ; then
> -       QEMU_CFLAGS="$QEMU_CFLAGS $flag"
> +    if compile_prog "-Werror $warning_flags $flag" "" ; then
> +       warning_flags="$warning_flags $flag"
>     fi
>  done
> +QEMU_CFLAGS="$QEMU_CFLAGS $warning_flags"

The compile_prog function honours QEMU_CFLAGS, so
adding each flag to QEMU_CFLAGS as we confirm it to work
should have the same effect, surely?

-- PMM