[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object |
|
Date: |
Mon, 02 Apr 2012 23:02:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 02/04/2012 22:56, Igor Mitsyanko ha scritto:
> 2) At first I made SD card child of SD host controller, but it most
> certainly wrong, it should be a link.
This is a bit thorny, because BlockDriverState exposes a slot and its
medium, not just the medium (you can have an empty BDS, and that is not
NULL).
I think the right place for the SD card would be a child of the block
device, but as block devices are not qdevified, for now it can be left
as a child of the host controller.
The patch looks good, except that I would prefer to have wrappers for
SD_GET_CLASS(foo)->method(args) in sd.h. It would also make the patch
much smaller.
Paolo
- Re: [Qemu-devel] [PATCH 3/6] hw/sd.c: make sd_dataready() return bool, (continued)
- [Qemu-devel] [PATCH 2/6] hw/sd.c: convert binary variables to bool, Igor Mitsyanko, 2012/04/02
- [Qemu-devel] [PATCH 5/6] hw/sd.c: add SD card save/load support, Igor Mitsyanko, 2012/04/02
- [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Igor Mitsyanko, 2012/04/02
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Peter Maydell, 2012/04/02
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Paolo Bonzini, 2012/04/02
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Igor Mitsyanko, 2012/04/02
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Peter Maydell, 2012/04/02
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Igor Mitsyanko, 2012/04/03
- Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 4/6] hw/sd.c: make sd_wp_addr() return bool, Igor Mitsyanko, 2012/04/02
[Qemu-devel] [PATCH 1/6] hw/sd.c: convert wp_groups in SDState to bitfield, Igor Mitsyanko, 2012/04/02