Re: [Qemu-devel] qdev property listing broken

[Peter Maydell]

On 2 April 2012 23:03, Paolo Bonzini <address@hidden> wrote:
> Il 02/04/2012 22:07, Peter Maydell ha scritto:
>> On 2 April 2012 20:40, Paolo Bonzini <address@hidden> wrote:
>>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>>> index a310cc7..923519c 100644
>>> --- a/hw/qdev-monitor.c
>>> +++ b/hw/qdev-monitor.c
>>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>>>          * for removal.  This conditional should be removed along with
>>>          * it.
>>>          */
>>> -        if (!prop->info->parse) {
>>> +        if (!prop->info->get) {
>>>             continue;           /* no way to set it, don't show */
>>>         }
>>
>> This looks really weird: there's no "get" method so we conclude
>> "no way to *set* it" ?? Is the comment wrong?
>
> See the comment above.

You mean
        /*
         * TODO Properties without a parser are just for dirty hacks.
         * qdev_prop_ptr is the only such PropertyInfo.  It's marked
         * for removal.  This conditional should be removed along with
         * it.
         */
?

That also looks odd now because we're no longer testing whether the
property has a parser... (plus doesn't qdev_prop_vlan also have no
parser ?)

-- PMM