[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c |
|
Date: |
Tue, 03 Apr 2012 13:47:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
Am 03.04.2012 10:38, schrieb Lai Jiangshan:
> queues are not just internal things for locks, split them.
>
> Signed-off-by: Lai Jiangshan <address@hidden>
> ---
> Makefile.objs | 2 +-
> qemu-coroutine-lock.c | 49 +------------------------------
> qemu-coroutine-queue.c | 76
> ++++++++++++++++++++++++++++++++++++++++++++++++
> trace-events | 4 ++-
> 4 files changed, 81 insertions(+), 50 deletions(-)
What's the point? qemu-coroutine-lock.c is already a small file (171
lines) and all functions in it are doing related things (they
synchronise coroutines). Splitting a small cohesive file into two tiny
halves isn't an improvement, IMO.
Kevin
- Re: [Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to co_runnable_queue, (continued)
- [Qemu-devel] [PATCH 04/10] coroutine: init co_runnable_bh during boot, Lai Jiangshan, 2012/04/03
- [Qemu-devel] [PATCH 03/10] coroutine: rename qemu_co_queue_next_bh() to qemu_co_process_runnable(), Lai Jiangshan, 2012/04/03
- [Qemu-devel] [PATCH 10/10] coroutine: add qemu_coroutine_run() wrapper, Lai Jiangshan, 2012/04/03
- [Qemu-devel] [PATCH 07/10] coroutine: split qemu-coroutine-lock.c, Lai Jiangshan, 2012/04/03
- [Qemu-devel] [PATCH 08/10] coroutine: process the coroutines woken by child when child yield, Lai Jiangshan, 2012/04/03
- Re: [Qemu-devel] [PATCH 01/10] coroutine: use qemu_coroutine_switch() directly, Paolo Bonzini, 2012/04/03