Re: [Qemu-devel] [RFC][PATCH v2 0/4] uq/master: Basic MSI support for in-kernel irqchip mode

[Michael S. Tsirkin]

On Tue, Apr 03, 2012 at 09:17:30PM +0200, Jan Kiszka wrote:
> On 2012-04-03 09:23, Jan Kiszka wrote:
> > This is v2 of the RFC, fixing a memory leak in
> > kvm_flush_dynamic_msi_routes and adding support for the proposed
> > KVM_SIGNAL_MSI IOCTL.
> > 
> > This series depends on "kvm: set gsi_bits and max_gsi correctly"
> > (http://thread.gmane.org/gmane.comp.emulators.kvm.devel/88906).
> > 
> > Jan Kiszka (4):
> >   kvm: Refactor KVMState::max_gsi to gsi_count
> >   kvm: Introduce basic MSI support for in-kernel irqchips
> >   KVM: x86: Wire up MSI support for in-kernel irqchip
> >   kvm: Add support for direct MSI injections
> > 
> >  hw/apic.c     |    3 +
> >  hw/kvm/apic.c |   33 +++++++++-
> >  hw/pc.c       |    5 --
> >  kvm-all.c     |  195 
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> >  kvm.h         |    1 +
> >  5 files changed, 225 insertions(+), 12 deletions(-)
> > 
> 
> As we obviously agreed on the general direction regarding an MSI
> injection interface, I think patches 1-3 can lose their RFC tags and are
> ready for uq/master (provided there are no further review comments).
> Patch 4 will be reworked once the kernel interface is finalized.
> 
> Jan

I agree.
Acked-by: Michael S. Tsirkin <address@hidden>

> -- 
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux