[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport* |
Date: |
Thu, 05 Apr 2012 12:50:09 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 |
On 04/04/2012 09:21 PM, Julien Grall wrote:
> This patch replaces all register_ioport* with portio_*. It permits to
> use the new Memory stuff like listener.
>
>
>
> +static const MemoryRegionPortio piix4_portio_list[] = {
> + { 0x00, 64, 1, .read = smb_ioport_readb, }, /* s->smb_io_base */
> + { 0x00, 64, 1, .write = smb_ioport_writeb, }, /* s->smb_io_base */
> + PORTIO_END_OF_LIST(),
> +};
> +
> +static const MemoryRegionPortio acpi_portio_list[] = {
> + { 0x00, 4, 4, .write = acpi_dbg_writel, }, /* ACPI_DBG_IO_ADDR */
> + PORTIO_END_OF_LIST(),
> +};
Please replace single-port lists with MemoryRegionOps (and MemoryRegions
in the state structure). I think I mentioned this in the first review,
but perhaps only about a single instance, sorry.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH V2 0/7] memory: unify ioport registration, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport*, Julien Grall, 2012/04/04
- Re: [Qemu-devel] [PATCH V2 2/7] hw/acpi_piix4.c: replace register_ioport*,
Avi Kivity <=
- [Qemu-devel] [PATCH V2 7/7] hw/apm.c: replace register_ioport*, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 4/7] hw/serial.c: replace register_ioport*, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 1/7] isa: add isa_address_space_io, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 6/7] hw/dma.c: replace register_ioport*, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 5/7] hw/pc.c: replace register_ioport*, Julien Grall, 2012/04/04
- [Qemu-devel] [PATCH V2 3/7] hw/cirrus_vga.c: replace register_ioport*, Julien Grall, 2012/04/04