Re: [Qemu-devel] [PATCH 1/1] Allow machines to configure the QEMU_VERSION that's exposed via hardware

[Peter Maydell]

On 5 April 2012 15:26, Crístian Viana <address@hidden> wrote:
> diff --git a/vl.c b/vl.c
> index ae91a8a..7fea263 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1561,7 +1561,8 @@ static void main_loop(void)
>
>  static void version(void)
>  {
> -    printf("QEMU emulator version " QEMU_VERSION QEMU_PKGVERSION ", 
> Copyright (c) 2003-2008 Fabrice Bellard\n");
> +    printf("QEMU emulator version %s" QEMU_PKGVERSION ", "
> +           "Copyright (c) 2003-2008 Fabrice Bellard\n", qemu_get_version());
>  }

This kind of change is definitely wrong -- where we're reporting
the QEMU version to the *user* we definitely don't want to introduce
the possibility of lying about it.

(This is distinct from reporting the QEMU version to the *guest*
via device manufacturer/version strings.)

-- PMM