[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block: close unused image files at the end
From: |
Federico Simoncelli |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block: close unused image files at the end of streaming |
Date: |
Thu, 05 Apr 2012 11:51:44 -0400 (EDT) |
----- Original Message -----
> From: "Paolo Bonzini" <address@hidden>
> To: address@hidden
> Cc: "Marcelo Tosatti" <address@hidden>, "Federico Simoncelli" <address@hidden>
> Sent: Thursday, April 5, 2012 5:42:58 PM
> Subject: [PATCH 4/7] block: close unused image files at the end of streaming
>
> From: Marcelo Tosatti <address@hidden>
>
> Close the now unused images that were part of the previous backing
> file
> chain and adjust ->backing_hd properly.
>
> Note that this only works with relative paths.
s/relative/absolute/
> Given the images:
>
> /tmp/a/base.raw
> /tmp/a/snap1.qcow2
> /tmp/b/snap2.qcow2
>
> chained as:
>
> base(bak:"") <- snap1(bak:"base.raw") <-
> snap2(bak:"../a/snap1.qcow2")
>
> merging snap1 and snap2 we will obtain:
>
> base(bak:"") <- snap2(bak:"base.raw")
>
> However this should be maintained by the user/admin: one can also
> screw up relative paths using qemu-img manually.
The patch is fine but I disagree with this comment. The user/admin didn't make
any mistake and he shouldn't be in charge of additional maintenance (which is
also tricky since the VM is running).
--
Federico
- [Qemu-devel] [PATCH 0/7] Miscellaneous fixes for block and snapshots, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 1/7] block: add mode argument to blockdev-snapshot-sync, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 2/7] block: fail live snapshot if disk has no medium, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 3/7] block: fix snapshot with QED format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 4/7] block: close unused image files at the end of streaming, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 4/7] block: close unused image files at the end of streaming,
Federico Simoncelli <=
- [Qemu-devel] [PATCH 5/7] block: pass new base image format to bdrv_change_backing_file, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 7/7] block: update in-memory backing file and format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 6/7] block: push bdrv_change_backing_file error checking up from drivers, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/7] Miscellaneous fixes for block and snapshots, Paolo Bonzini, 2012/04/12