Re: [Qemu-devel] [PATCH] versatilepb: add i2c support

[Oskar Andero]

On 18:45 Thu 05 Apr     , Peter Maydell wrote:
> On 2 April 2012 21:17, Oskar Andero <address@hidden> wrote:
> > Signed-off-by: Oskar Andero <address@hidden>
> > ---
> >  hw/versatilepb.c |   80 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 80 insertions(+), 0 deletions(-)
> 
> This is just a cut-n-paste of the i2c device in hw/realview.c.
> Instead of duplicating the code we should pull it out into
> its own source file, give it a name which doesn't have 'realview'
> in it (since it's the same thing in all these boards) and
> then use that new device in all the boards which have it.

Yes, you are absolutely right. I will create a new file, e.g.
i2c_generic.c or something.

Thanks,
 Oskar