Re: [Qemu-devel] [PATCH v2 2/5] acpi_piix4: Fix PCI hotplug race

[Marcelo Tosatti]

On Tue, Apr 10, 2012 at 12:38:09PM -0600, Alex Williamson wrote:
> > > > It's probably harmless if we do let it be clobbered by migration
> > > > though: worst case we lose an event and that might have
> > > > happened before migration :)
> > > 
> > > Perhaps that's another way to manage it, just let it be a lazy
> > > accumulation of anything that has been hotadded.  That makes debug hard
> > > though because we can't know what should be set without looking that the
> > > entire history of the vm, versus something like "device present", which
> > > we can verify at any point in time.  Thanks,
> > > 
> > > Alex
> > 
> > Good point. I think Marcelo's comment can be addressed
> > if you rename up to up_ignored, old_up, up_legacy or something
> > like that.
> 
> Easy enough to rename .up to .old_up.  Marcelo, are you looking for more
> than that?  Thanks,
> 
> Alex

Its fine the way it is actually, since the patch adds a comment
mentioning that "up" is not used (and one can easily check the logs to
understand).

Patchset looks good to me, thanks.