Re: [Qemu-devel] [PATCH 1/1 v2] Allow machines to configure the QEMU_VERSION that's exposed via hardware

[Anthony Liguori]

On 04/11/2012 02:14 AM, Peter Maydell wrote:
> On 11 April 2012 02:50, Anthony Liguori<address@hidden>  wrote:
> > On 04/10/2012 04:24 PM, Peter Maydell wrote:
> > > This is still changing the version printed in a bunch of user
> > > facing usage and help messages. Please drop those.
> >
> >
> > Why? Changing the help messages is not necessary or useful.  We just need to
> > make sure the guest ABI remains stable.
>
> Er, you seem to be furiously agreeing with me? This
> patch includes hunks that change how we handle eg
> usage messages for bsd-user and qemu-img. I agree with
> you that we should not be changing those, so why are
> they in the patch?

Sorry, I misread your note.  I agree with you completely.

Regards,

Anthony Liguori

> I'm also suspicious about lying about the version string
> in the monitor interface, but I'm not a monitor expert
> so you'll have to tell me whether that one's right.
>
> Oh, and osdep.c is definitely the wrong place to define
> qemu_{set,get}_version().
>
> -- PMM