qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implement


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.
Date: Wed, 11 Apr 2012 14:10:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120310 Thunderbird/11.0

On 04/11/2012 02:08 PM, Paolo Bonzini wrote:
Il 11/04/2012 19:25, Anthony Liguori ha scritto:

Off the top of my head: issues with v5:
polluting global namespace, must scope names
appropriately with vmxnet_ VMXNET_ unless they have file scope.
Don't use names with _ followed by an upper case letter
or that star with two underscores. Don't mix underscores and mixed case.
Don't stick any new types in net.c/pci.c - new devices should use -device
not -net. Global stuff like ethernet header size
should move to central place instead of copy paste.

I'd like to see qtest test cases for this too.

I think as things stand it is a bit too much to request this.  You're
basically asking to write a libos.

The only functionality you need is PCI device enumeration which is pretty much dead simple.

What other functions would you need a libos for?

Regards,

Anthony Liguori


Paolo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]