[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] realview: break out the i2c controller c
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] realview: break out the i2c controller code |
Date: |
Wed, 11 Apr 2012 14:50:18 +0100 |
User-agent: |
KMail/1.13.7 (Linux/3.0.0-2-amd64; KDE/4.6.5; x86_64; ; ) |
> +++ b/hw/versatile_i2c.c
> @@ -0,0 +1,102 @@
> +/*
> + * Versatile I2C controller
I'd go for "ARM Versatile I2C controller".
I wish companies wouldn't pick generic terms as product names :-( That's not
your fault though!
> + *
> + * Copyright (C) 2012 Oskar Andero <address@hidden>
AFAICS You've copy/pasted this from versatilepb.c, so you should inherit the
copyright from there.
Adding a copyright line for yourself is OK (though I'm not entirely sure which
code you'd actually be able to claim).
Changing from my lazy one-line statement to the more verbose boilerplate is
also OK.
Paul