[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/24] qdev: remove qdev_prop_set_defaults
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 12/24] qdev: remove qdev_prop_set_defaults |
Date: |
Wed, 11 Apr 2012 23:30:30 +0200 |
Fold its functionality in qdev_property_add_static.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-properties.c | 22 ----------------------
hw/qdev.c | 26 +++++++++++++++++++++++---
hw/qdev.h | 1 -
3 files changed, 23 insertions(+), 26 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index bf46075..60fef9a 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -1084,28 +1084,6 @@ void qdev_prop_set_ptr(DeviceState *dev, const char
*name, void *value)
*ptr = value;
}
-void qdev_prop_set_defaults(DeviceState *dev, Property *props)
-{
- Object *obj = OBJECT(dev);
- if (!props)
- return;
- for (; props->name; props++) {
- Error *errp = NULL;
- if (props->qtype == QTYPE_NONE) {
- continue;
- }
- if (props->qtype == QTYPE_QBOOL) {
- object_property_set_bool(obj, props->defval, props->name, &errp);
- } else if (props->info->enum_table) {
- object_property_set_str(obj,
props->info->enum_table[props->defval],
- props->name, &errp);
- } else if (props->qtype == QTYPE_QINT) {
- object_property_set_int(obj, props->defval, props->name, &errp);
- }
- assert_no_error(errp);
- }
-}
-
static QTAILQ_HEAD(, GlobalProperty) global_props =
QTAILQ_HEAD_INITIALIZER(global_props);
static void qdev_prop_register_global(GlobalProperty *prop)
diff --git a/hw/qdev.c b/hw/qdev.c
index fb3b961..f371248 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -571,6 +571,9 @@ void qdev_property_add_legacy(DeviceState *dev, Property
*prop,
void qdev_property_add_static(DeviceState *dev, Property *prop,
Error **errp)
{
+ Error *local_err = NULL;
+ Object *obj = OBJECT(dev);
+
/*
* TODO qdev_prop_ptr does not have getters or setters. It must
* go now that it can be replaced with links. The test should be
@@ -580,10 +583,28 @@ void qdev_property_add_static(DeviceState *dev, Property
*prop,
return;
}
- object_property_add(OBJECT(dev), prop->name, prop->info->name,
+ object_property_add(obj, prop->name, prop->info->name,
prop->info->get, prop->info->set,
prop->info->release,
- prop, errp);
+ prop, &local_err);
+
+ if (local_err) {
+ error_propagate(errp, local_err);
+ return;
+ }
+ if (prop->qtype == QTYPE_NONE) {
+ return;
+ }
+
+ if (prop->qtype == QTYPE_QBOOL) {
+ object_property_set_bool(obj, prop->defval, prop->name, &local_err);
+ } else if (prop->info->enum_table) {
+ object_property_set_str(obj, prop->info->enum_table[prop->defval],
+ prop->name, &local_err);
+ } else if (prop->qtype == QTYPE_QINT) {
+ object_property_set_int(obj, prop->defval, prop->name, &local_err);
+ }
+ assert_no_error(local_err);
}
static void device_initfn(Object *obj)
@@ -606,7 +627,6 @@ static void device_initfn(Object *obj)
qdev_property_add_legacy(dev, prop, NULL);
qdev_property_add_static(dev, prop, NULL);
}
- qdev_prop_set_defaults(dev, DEVICE_CLASS(class)->props);
class = object_class_get_parent(class);
} while (class != object_class_by_name(TYPE_DEVICE));
qdev_prop_set_globals(dev);
diff --git a/hw/qdev.h b/hw/qdev.h
index 3bef10c..aea53c8 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -307,7 +307,6 @@ void qdev_prop_set_macaddr(DeviceState *dev, const char
*name, uint8_t *value);
void qdev_prop_set_enum(DeviceState *dev, const char *name, int value);
/* FIXME: Remove opaque pointer properties. */
void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value);
-void qdev_prop_set_defaults(DeviceState *dev, Property *props);
void qdev_prop_register_global_list(GlobalProperty *props);
void qdev_prop_set_globals(DeviceState *dev);
--
1.7.9.3
- Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type, (continued)
- [Qemu-devel] [PATCH v2 05/24] qdev: push "type" property up to Object, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 06/24] qdev: fix -device foo,?, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 08/24] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 07/24] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 09/24] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 11/24] qdev: clean up global properties, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 10/24] qdev: move bus properties to abstract superclasses, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 12/24] qdev: remove qdev_prop_set_defaults,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 13/24] qapi: add Visitor interfaces for uint*_t and int*_t, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 14/24] qdev: use int32_t container for devfn property, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 15/24] qdev: switch property accessors to fixed-width visitor interfaces, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 17/24] qdev: remove qdev_prop_exists, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 16/24] qdev: remove PropertyInfo range checking, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 18/24] qdev: push state up to Object, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 23/24] qdev: implement qdev_init on top of realize, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 24/24] qdev: split part of device_finalize to device_unrealize, Paolo Bonzini, 2012/04/11
- [Qemu-devel] [PATCH v2 21/24] qom: push static properties to Object, Paolo Bonzini, 2012/04/11