Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid()

[Brad Smith]

On 11/04/12 4:55 PM, Peter Maydell wrote:
> On 11 April 2012 20:23, Brad Smith<address@hidden>  wrote:
> > The following commit broke the build..
> >
> > linux-user: take RESERVED_VA into account for g2h_valid()
>
> Whoops. bsd-user is a bit unloved, I'm afraid. Can you try the
> following one-line fix? If it works then I'll submit it to the mailing
> list as a proper patch.

This fixes this particular issue.

> ===begin===
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 48cb715..0689e38 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -41,6 +41,7 @@ int singlestep;
>   unsigned long mmap_min_addr;
>   unsigned long guest_base;
>   int have_guest_base;
> +unsigned long reserved_va;
>   #endif
>
>   static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
> ===endit===
>
> I think we've broken darwin-user as well, but that is even less loved
> and there was a discussion on IRC a while back about simply removing it.
>
> -- PMM

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.