Re: [Qemu-devel] [PATCH 1/7] block: add mode argument to blockdev-snapshot-sync

[Kevin Wolf]

Am 05.04.2012 17:42, schrieb Paolo Bonzini:
> This was missing in the patch that added the argument.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qmp-commands.hx |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 9447871..a5accc9 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -762,7 +762,7 @@ EQMP
>  
>      {
>          .name       = "blockdev-snapshot-sync",
> -        .args_type  = "device:B,snapshot-file:s,format:s?",
> +        .args_type  = "device:B,snapshot-file:s,format:s,mode:s?",

But format should probably still stay optional.

Kevin