[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] block: fix snapshot with QED format
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] block: fix snapshot with QED format |
Date: |
Thu, 12 Apr 2012 12:55:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 05.04.2012 17:42, schrieb Paolo Bonzini:
> QED's opaque data includes a pointer back to the BlockDriverState.
> Creating a snapshot whose format is QED breaks the relationship when
> bdrv_append shuffles data between bs_new and bs_top. To avoid this,
> add a "rebind" function that tells the driver about the new relationship
> between the BlockDriverState and its opaque.
>
> The patch also adds rebind to VVFAT for completeness, even though it is
> not used with live snapshots.
>
> Thanks to Stefan and Jeff for help reproducing and debugging this.
>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: Jeff Cody <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
These drivers should really have been written in a way that they pass bs
instead of s when they need bs. I know that fixing the drivers properly
is much more work than adding another API that shouldn't exist in the
first place, so I'll take this anyway, but I do dislike it.
Kevin
- [Qemu-devel] [PATCH 0/7] Miscellaneous fixes for block and snapshots, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 1/7] block: add mode argument to blockdev-snapshot-sync, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 2/7] block: fail live snapshot if disk has no medium, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 3/7] block: fix snapshot with QED format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 4/7] block: close unused image files at the end of streaming, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 5/7] block: pass new base image format to bdrv_change_backing_file, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 7/7] block: update in-memory backing file and format, Paolo Bonzini, 2012/04/05
- [Qemu-devel] [PATCH 6/7] block: push bdrv_change_backing_file error checking up from drivers, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 0/7] Miscellaneous fixes for block and snapshots, Paolo Bonzini, 2012/04/12