[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bsd-user: fix compile failure
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] bsd-user: fix compile failure |
Date: |
Thu, 12 Apr 2012 12:38:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 12.04.2012 12:22, schrieb Peter Maydell:
> bsd-user doesn't actually support reserving a memory area for the
> guest address space, but we need to at least define the reserved_va
> global so that cpu-all.h's RESERVED_VA macro will work correctly.
>
> This fixes a compilation error introduced in commit
Did you forget to paste the commit hash here? Otherwise a "the" seems
missing.
> which added a use of RESERVED_VA to h2g_valid().
>
Reported-by: Brad Smith <address@hidden>
from what I remember.
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> bsd-user/main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 48cb715..0689e38 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -41,6 +41,7 @@ int singlestep;
> unsigned long mmap_min_addr;
> unsigned long guest_base;
> int have_guest_base;
> +unsigned long reserved_va;
> #endif
>
> static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
Looks okay to me but don't have BSD setup to test.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg