Re: [Qemu-devel] [PATCH v2] qom: Introduce object_realize_nofail()

[Anthony Liguori]

On 04/12/2012 09:04 AM, Andreas Färber wrote:
> Am 12.04.2012 16:59, schrieb Paolo Bonzini:
> > Il 12/04/2012 16:47, Anthony Liguori ha scritto:
> > > > Wrap setting of Object::realized property, error reporting and exit(1)
> > > > into a helper function. It is the equivalent of qdev_init_nofail().
> > >
> > > I don't like this.
> > >
> > > If for no reason other than, a much more specific justification is
> > > needed for this.  I absolutely don't want to repeat the error handling
> > > mistakes of qdev.  I would rather we refactor all of the users of
> > > qdev_init_nofail() to propagate errors.
> >
> > I agree about this in general, but for a different reason.  There should be
> > only one call to object_realize_nofail, in vl.c, which might as well be
> > inlined---I'll include it in my series.  All calls to qdev_init_nofail
> > and qdev_init should disappear from boards that are properly converted
> > to QOM.
>
> We had talked about this on IRC and found that it won't work for
> selecting the type of an object.

Can you be more specific?

Selecting the type of an object should be done by having a link<> property and 
letting the user create an object and setup the link.

Properties should not be used to magically fill in link<> properties.

Regards,

Anthony Liguori

> I can work around it in the sh4 case but the problem stays.
>
> Andreas