Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

[Andreas Färber]

Am 12.04.2012 18:11, schrieb Paolo Bonzini:
> Il 12/04/2012 18:09, Andreas Färber ha scritto:
>> I think I had suggested static const and moving them to before the
>> register_types() function?
> 
> I'm not sure why that would be useful...

Well, I'm not sure why Anthony is doing it differently from everywhere
else here. :)

Outside function:
Since you move it to the bottom of the file now (which I appreciate)
there's no need to shield it against misuse.

const:
Moves it to different ELF section iiuc and assures no unintentional
modification. We do that for the MemoryRegionOps and I am planning to
post a patch to clean up all old TypeInfo uses (in an intermediate step
by Anthony it was being used in a non-const way) so that they don't
propagate further in the code.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg