Re: [Qemu-devel] [PATCH v2 04/24] qom: make Object a type

[Andreas Färber]

Am 11.04.2012 23:30, schrieb Paolo Bonzini:
> Right now the base Object class has a special NULL type.  Change this so
> that we will be able to add class_init and class_base_init callbacks.
> To do this, remove some special casing of ObjectClass that is not really
> necessary.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>

I had also pointed out that no longer handling .parent = NULL as
TYPE_OBJECT can have unwanted effects of not deriving some objects from
TYPE_OBJECT. I see no statement that the code was reviewed for TypeInfos
that don't set .parent (or set it to NULL). Nor do I see the suggested
check against whitelisted base classes "object" and "interface" to
detect such uses at startup. Do you want a patch for that, forgot or
decided against?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg