[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests |
|
Date: |
Fri, 13 Apr 2012 11:59:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 13/04/2012 11:52, Zhi Yong Wu ha scritto:
>> > FWIW, live snapshot during guest boot (block_set_io_throttle ide0-hd0 0
>> > 500000 500000 0 500000 500000) died immediately without the patches.
>> > With the patch I could do 20 snapshots before I stopped.
> Why do you not use qemu_aio_flush before loop start? it can fix the
> issue said by me.
I won't modify a patch without understanding what's going on. From my
understanding (which may well be wrong), replacing qemu_aio_wait() with
qemu_aio_flush() should have no effect in this patch.
In other words, you didn't provide enough justification to make me
understand why there is a problem and why the change fixes it. Did you
see a problem with all the patches, or with this one in isolation (which
actually would not compile alone, and this should be a red flag alone)?
How did you reproduce it?
Paolo
- [Qemu-devel] [PATCH 02/26] qemu-tool: map vm_clock to rt_clock, (continued)
- [Qemu-devel] [PATCH 02/26] qemu-tool: map vm_clock to rt_clock, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 03/26] posix-aio: merge posix_aio_process_queue and posix_aio_read, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 05/26] aio: return "AIO in progress" state from qemu_aio_wait, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 04/26] aio: remove process_queue callback and qemu_aio_process_queue, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Paolo Bonzini, 2012/04/12
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Zhi Yong Wu, 2012/04/12
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Paolo Bonzini, 2012/04/13
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Zhi Yong Wu, 2012/04/13
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Paolo Bonzini, 2012/04/13
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Zhi Yong Wu, 2012/04/13
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Zhi Yong Wu, 2012/04/13
- Re: [Qemu-devel] [PATCH 07/26] block: add the support to drain throttled requests, Zhi Yong Wu, 2012/04/13
[Qemu-devel] [PATCH 08/26] block: add mode argument to blockdev-snapshot-sync, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 06/26] aio: simplify qemu_aio_wait, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 09/26] block: fail live snapshot if disk has no medium, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 10/26] block: fix snapshot on QED, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 14/26] block: fix allocation size for dirty bitmap, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 12/26] block: update in-memory backing file and format, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 11/26] block: push bdrv_change_backing_file error checking up from drivers, Paolo Bonzini, 2012/04/12
[Qemu-devel] [PATCH 13/26] block: open backing file as read-only when probing for size, Paolo Bonzini, 2012/04/12