qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/19] qcow2: Ignore reserved bits in L1/L2 entr


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 06/19] qcow2: Ignore reserved bits in L1/L2 entries
Date: Fri, 13 Apr 2012 13:33:03 +0100

On Thu, Apr 12, 2012 at 4:01 PM, Kevin Wolf <address@hidden> wrote:
> This changes the still existing places that assume that the only flags
> are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out
> reserved bits.
>
> It does not convert bdrv_check yet.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/qcow2-cluster.c  |   26 +++++++++++++-------------
>  block/qcow2-refcount.c |   12 ++++++------
>  2 files changed, 19 insertions(+), 19 deletions(-)

It would be interesting to run a test case where we artifically set a
reserved bit to gain confidence that no important codepath has been
missed.  Thoughts?

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]