[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts |
|
Date: |
Fri, 13 Apr 2012 14:46:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 13/04/2012 14:42, Takayuki Konishi ha scritto:
>> > - if (!max_cpus)
>> > + if (qemu_opts_foreach(qemu_find_opts("smp"), smp_init_func, NULL, 1)
>> > != 0) {
>> > + exit(1);
>> > + }
>> > + if (!max_cpus) {
>> > max_cpus = smp_cpus;
>> > -
>> > + }
> Isn't this 'if' block redundant? smp_init_func sets max_cpus = smp_cpus if
> !max_cpus.
smp_init_func is only run if -smp is given on the command line, just
like smp_parse before this patch.
Paolo