Re: [Qemu-devel] [PATCH v8 0/8] Rewrite tracetool using python modules

[Lluís Vilanova]

Stefan Hajnoczi writes:

> Excellent, thank you!

> There was a conflict qemu.git/master and Patch 1 which I have tried to
> resolve.  I also added commit descriptions to the first and last patches
> to capture the rationale behind these changes.

> Please check the tracing tree to confirm that you are happy with the
> merge:

I've looked at the differences for the first patch, and most of them can be
ignored.

The only exception is the addition of some extra reserved words to account for
in 'tracetool.backend.dtrace.stap'. Words 'in', 'next' and 'self' were added but
are not present now after the rewrite.

Please add an extra commit in your tree re-adding the new dtrace reserved words.

Other than that, looks legit :)


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth