Re: [Qemu-devel] [PATCH v2] os-posix: Fix build on FreeBSD

[Andreas Färber]

Am 14.04.2012 16:01, schrieb �:
> From: Nathan Whitehorn <address@hidden>
> 
> Add an include for a header required to build on recent FreeBSD.
> 
> Signed-off-by: Nathan Whitehorn <address@hidden>
> Signed-off-by: Andreas F�rber <address@hidden>
> ---

Sorry, looks like FreeBSD doesn't play well with UTF-8 or I am just too
stupid to configure... hope the committer can fix.

For testing my upcoming CPUState series I've set up a FreeBSD
9.0-RELEASE VM. Apart from this issue that hadn't been followed up yet I
am also seeing very annoying warnings about __FreeBSD_version not being
defined (annoying because it's being used in qemu-timer.h since 2008 and
therefore affects virtually every source file). Is some include missing?
Was it dropped?

With that check commented out, I am seeing some errors from
hw/usb/host-bsd.c:

In file included from /usr/home/andreas/QEMU/qemu/hw/usb/host-bsd.c:38:
/usr/include/dev/usb/usb.h:717: error: expected identifier before
numeric constant
/usr/include/dev/usb/usb.h:750: error: expected identifier before
numeric constant
/usr/home/andreas/QEMU/qemu/hw/usb/host-bsd.c: In function
'usb_host_handle_control':
/usr/home/andreas/QEMU/qemu/hw/usb/host-bsd.c:133: error: storage size
of 'req' isn't known
[...]

Apparently the first issue is USB_SPEED_SUPER and USB_STATE_ATTACHED
being used in a system enum whereas QEMU #defines them to some value?

Andreas