Re: [Qemu-devel] [PATCH] tests: remove .SECONDARY special target

[Blue Swirl]

On Sat, Mar 31, 2012 at 10:50, Paolo Bonzini <address@hidden> wrote:
> The special target should not be needed anymore, and caused (perhaps
> due to a Make bug) a failure with "make -j2".  In any case, the
> main makefile is a better place for such special targets rather
> than an included makefile.
>
> Reported-by: Luiz Capitulino <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Thanks, applied.

> ---
>        Anthony, this was taken from your patches, do you remember
>        why it's needed?  I changed the rules to use the GNU Make
>        "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
>        should be no implicit rules anymore and .SECONDARY should
>        not be needed.
>
>  tests/Makefile |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 17f6ece..25a972a 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,8 +74,6 @@ check-help:
>       address@hidden "Default options are -k and (for make V=1) --verbose; 
> they can be"
>       address@hidden "changed with variable GTESTER_OPTIONS."
>
> -.SECONDARY:
> -
>  SPEED = quick
>  GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
>
> --
> 1.7.9.1
>
>