Re: [Qemu-devel] [PATCH 08/36] vmstate: machine.c is only compiled for !CONFIG_USER_ONLY

[Andreas Färber]

Am 21.03.2012 20:20, schrieb Peter Maydell:
> On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>>  target-ppc/machine.c |    8 --------
>>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> Could we give this patch a more informative commit message,
> please? In particular it doesn't actually say that this is
> fixing a ppc-only problem. My suggestion:
> 
> ===begin===
> target-ppc/machine.c: Drop unnecessary ifdefs
> 
> machine.c is only compiled for softmmu targets, so checks for
> !defined(CONFIG_USER_ONLY) are unnecessary and can be dropped.
> ===endit===

Thanks, applied with the suggested commit message to ppc-next:
http://repo.or.cz/w/qemu/agraf.git/shortlog/refs/heads/ppc-next

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg