Re: [Qemu-devel] [PATCH v2 1/2] hw/exynos4210.c: Access gate_irq by using group size.

[Peter Maydell]

On 12 April 2012 09:13, Evgeny Voevodin <address@hidden> wrote:
> New EXYNOS4210_IRQ_GATE_GROUP_SIZE introduced and
> EXYNOS4210_IRQ_GATE_NINPUTS changed from 8 to 4, because
> having 8 inputs makes an input group of size 4 and access to
> second's group first input leads to pass it into third instead of
> second output of gate.

I'm afraid I can't make any sense of this commit message :-(

> -#define EXYNOS4210_IRQ_GATE_NINPUTS 8
> +#define EXYNOS4210_IRQ_GATE_NINPUTS 4

You can't change this without bumping the exynos4210.irq_gate VMState
version, because it's used as the array size there. I think you're
just going to have to merge these two patches into one.

> +#define EXYNOS4210_IRQ_GATE_GROUP_SIZE (EXYNOS4210_IRQ_GATE_NINPUTS / \
> +                                                            EXYNOS4210_NCPUS)

Minor nit, I think putting the line break like this:

#define EXYNOS4210_IRQ_GATE_GROUP_SIZE \
    (EXYNOS4210_IRQ_GATE_NINPUTS / EXYNOS4210_NCPUS)

is more readable.

-- PMM