Re: [Qemu-devel] [PATCH 3/3] qtest: add m48t59 tests for Sparc

[Andreas Färber]

Am 15.04.2012 18:32, schrieb Blue Swirl:
> Add simple m48t59 qtests, enable test only for Sparc32
> and Sparc64. On PPC, the device is behind PCI bus.
> 
> Signed-off-by: Blue Swirl <address@hidden>
> ---
>  tests/Makefile      |    5 +
>  tests/m48t59-test.c |  259 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 264 insertions(+)
>  create mode 100644 tests/m48t59-test.c
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index baf1d70..04a8050 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -20,6 +20,10 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>  # really in libqtest, not in the testcases themselves.
>  check-qtest-i386-y = tests/rtc-test
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
> +#check-qtest-ppc-y = tests/m48t59-test
> +#check-qtest-ppc64-y = tests/m48t59-test
> +check-qtest-sparc-y = tests/m48t59-test
> +check-qtest-sparc64-y = tests/m48t59-test

For Stefan not to hang you, you should probably add $(EXESUF). ;)

Some way of not duplicating the test four times would be nice. Maybe
$(check-qtest-m48t59-y) or at least $(check-qtest-sparc-y) for sparc64?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg