Re: [Qemu-devel] [PATCH v3 07/13] target-sh4: Make increment_urc() take SuperHCPU

[Andreas Färber]

Am 16.04.2012 16:53, schrieb Peter Maydell:
> On 14 April 2012 23:12, Andreas Färber <address@hidden> wrote:
>> Signed-off-by: Andreas Färber <address@hidden>
> 
> Is this really an improvement?

Yes, these patches are propagating the use of QOM *CPU throughout code
so that we can gradually drop *_env_get_cpu() calls and at some point
remove it completely. Expect to see more of such incremental cleanups in
the followup series - having CPUState be QOM in 03/13 is not the end
goal, it's having the code actually use it instead of CPU*State. General
idea is CPUArchState -> CPUState (therefore the automated CPUState ->
CPU*State refactorings) and CPU*State -> *CPU except for TCG (Richard's
pointer-to-middle concept, therefore "first member of" in the various
conversions).

Looking at this particular patch again, adding a local env variable
would avoid some of the cpu->env.* accesses. That should be better.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg