[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] signrom: Rewrite as python script
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH v2] signrom: Rewrite as python script |
Date: |
Mon, 16 Apr 2012 17:53:44 +0200 |
On 29.03.2012, at 19:44, Jan Kiszka wrote:
> On 2012-03-05 15:09, Jan Kiszka wrote:
>> Now that we have a hard dependency on python anyway, we can replace the
>> slow shell script to calculate the option ROM checksum with a fast AND
>> portable python version. Tested both with python 2.7 and 3.1.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>
>> Changes in v2:
>> - Switch to GPLv2+.
>> The tool replaces an inefficient GPLv2+ implementation, so want to
>> avoid any license "regression". As it is self-contained, it doesn't
>> affect the QEMU core license anyway (which least common denominator
>> remains GPLv2).
>>
>
> Ping?
Looks good and reasonable to me :). In general I prefer shell script over
python, but I'm fairly sure your version is a lot faster.
Alex
- Re: [Qemu-devel] [PATCH v2] signrom: Rewrite as python script,
Alexander Graf <=