Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device implementation Interface type "vmxnet3" added.

[Anthony Liguori]

On 04/15/2012 04:16 AM, Yan Vugenfirer wrote:
> On Wed, Apr 11, 2012 at 10:10 PM, Anthony Liguori<address@hidden>  wrote:
> > On 04/11/2012 02:08 PM, Paolo Bonzini wrote:
> > > Il 11/04/2012 19:25, Anthony Liguori ha scritto:
> > > > > Off the top of my head: issues with v5:
> > > > > polluting global namespace, must scope names
> > > > > appropriately with vmxnet_ VMXNET_ unless they have file scope.
> > > > > Don't use names with _ followed by an upper case letter
> > > > > or that star with two underscores. Don't mix underscores and mixed case.
> > > > > Don't stick any new types in net.c/pci.c - new devices should use
> > > > > -device
> > > > > not -net. Global stuff like ethernet header size
> > > > > should move to central place instead of copy paste.
> > > >
> > > >
> > > > I'd like to see qtest test cases for this too.
> > >
> > >
> > > I think as things stand it is a bit too much to request this.  You're
> > > basically asking to write a libos.
> >
> >
> > The only functionality you need is PCI device enumeration which is pretty
> > much dead simple.
> >
> > What other functions would you need a libos for?
> >
> > Regards,
> >
> > Anthony Liguori
> >
> > > Paolo
>
> Regarding the testing - we ran WHQL networking tests on the device. If
> we provide the logs will it be sufficient? I believe the test coverage
> is much more comprehensive than anything that we will do with qtest.

I'm not sure I'd agree about comprehensive, but the problem with WHQL is that 
it's not reproducible.

As you've seen from this thread, there's no a tremendous amount of interest in 
supporting this device.  Since it's likely you'll be the only ones using it, 
having an in-tree test case will help reduce the maintenance burden for everyone 
else.

But VMXNET3 isn't really special here.  From this point forward, I would expect 
all new devices to come with a qtest-based test case.

Regards,

Anthony Liguori

> Best regards,
> Yan.