Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion

[Alexander Graf]

On 16.04.2012, at 21:12, Blue Swirl wrote:

> On Mon, Apr 16, 2012 at 16:53, Alexander Graf <address@hidden> wrote:
>> 
>> On 31.03.2012, at 18:25, Blue Swirl wrote:
>> 
>>> Split PPC op helpers, convert to AREG0 free operation. Survives simple 
>>> tests.
>>> 
>>> FPU and SPE as well as integer and vector ops could be split further,
>>> each to their own file. This can be done also later.
>>> 
>>> It could be possible to move some code from hw/ppc.c to various
>>> helpers but that can also be done later.
>>> 
>>> Actually exceptions (#12 to #14) should have been converted before
>>> others because they can be called from code without AREG0 set up.
>>> 
>>> URL   git://repo.or.cz/qemu/blueswirl.git
>>>       http://repo.or.cz/r/qemu/blueswirl.git
>> 
>> Very nice patch set!
>> 
>> If you can update it on top of ppc-next and add patch descriptions in every 
>> patch (more than just the subject line), I'll happily apply it and if 
>> possible also pull it in before the hard freeze.
> 
> OK. Thanks for the review. But I'd prefer to apply them directly to
> qemu.git, because I'm using StGit for the patch stack and it doesn't
> work with different branches. Perhaps you could send a PULL for
> ppc-next, I'll push that and then rebase the patches?

Sounds great, but I need to catch up with Andreas and check what needs to be 
done to coordinate this properly with the QOM conversion. I'll try to get that 
done tomorrow, so by tomorrow night I should have a pull request out with 
whatever is left outstanding :).

And then based on that, I'd be more than happy to have you apply them to 
qemu.git.


Alex