qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets
Date: Mon, 16 Apr 2012 20:16:47 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 04/16/2012 05:54 PM, Peter Maydell wrote:
On 15 April 2012 17:32, Blue Swirl<address@hidden>  wrote:
Skip ROM or kernel loading and TCG init for qtest.

For Xtensa there is no default board and the
default board (g3beige) for PPCEMB seems to be wrong.

Signed-off-by: Blue Swirl<address@hidden>
---
  hw/an5206.c                   |    4 +-
  hw/axis_dev88.c               |    4 ++
  hw/collie.c                   |    3 ++
  hw/exynos4_boards.c           |    8 +++-
  hw/highbank.c                 |    3 ++
  hw/integratorcp.c             |    3 ++
  hw/mainstone.c                |    3 ++
  hw/mcf5208.c                  |    3 ++
  hw/mips_fulong2e.c            |   49 ++++++++++++-----------
  hw/mips_jazz.c                |   31 ++++++++-------
  hw/mips_malta.c               |   88 +++++++++++++++++++++--------------------
  hw/mips_mipssim.c             |   39 +++++++++---------
  hw/musicpal.c                 |    3 ++
  hw/omap_sx1.c                 |    2 +-
  hw/palm.c                     |    2 +-
  hw/realview.c                 |    3 ++
  hw/s390-virtio.c              |   68 +++++++++++++++----------------
  hw/shix.c                     |   28 +++++++------
  hw/spitz.c                    |    3 ++
  hw/tosa.c                     |    3 ++
  hw/versatilepb.c              |    3 ++
  hw/vexpress.c                 |    4 +-
  hw/xilinx_zynq.c              |    3 ++
  target-alpha/translate.c      |    4 +-
  target-cris/translate.c       |    5 ++-
  target-m68k/helper.c          |    2 +-
  target-microblaze/translate.c |    3 +-
  target-mips/translate.c       |    4 +-
  target-sh4/translate.c        |    4 +-
  target-sparc/cpu.c            |    4 +-
  30 files changed, 228 insertions(+), 158 deletions(-)

Yuck! Nack, this is way too invasive. Testing frameworks
shouldn't require random pointless changes to every board
model.

I think the issue is that all of these machines mandate a -kernel option. qtest doesn't care if you pass a -kernel but requiring a kernel in order to test a device sucks especially if you don't possess the toolchain to build such a kernel.

I think we should probably refactor the boards to do something more useful if a kernel isn't specified verses just buggering out.

Regards,

Anthony Liguori


-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]