Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

[Paolo Bonzini]

Il 17/04/2012 01:37, Igor Mammedov ha scritto:
> From: Igor Mammedov <address@hidden>
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  target-i386/helper.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index de7637c..1996b97 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1134,6 +1134,7 @@ CPUX86State *cpu_x86_init(const char *cpu_model)
>      X86CPU *cpu;
>      CPUX86State *env;
>      Error *errp = NULL;
> +    char cpuname[8];
>  
>      cpu = X86_CPU(object_new(TYPE_X86_CPU));
>      env = &cpu->env;
> @@ -1146,6 +1147,9 @@ CPUX86State *cpu_x86_init(const char *cpu_model)
>          }
>      }
>  
> +    snprintf(cpuname, sizeof(cpuname), "cpu%d", env->cpuid_apic_id);
> +    object_property_add_child(container_get("/machine"), cpuname, 
> OBJECT(cpu), NULL);
> +
>      object_property_set_bool(OBJECT(cpu), true, "realized", &errp);
>      if (errp) {
>          object_delete(OBJECT(cpu));

I think the right name would be /machine/cpu[%d]/cpu.  The local APIC
for example should reside under /machine/cpu[%d]/apic.

Paolo