[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 27/26] block: another bdrv_append fix
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 27/26] block: another bdrv_append fix |
Date: |
Tue, 17 Apr 2012 17:32:11 +0200 |
bdrv_append must also copy open_flags to the top, because the snapshot
has BDRV_O_NO_BACKING set. This causes interesting results if you
later use drive-reopen (not upstream) to reopen the image, and lose
the backing file in the process.
Signed-off-by: Paolo Bonzini <address@hidden>
---
A last minute addition...
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 1f4f476..9c7d896 100644
--- a/block.c
+++ b/block.c
@@ -934,6 +934,7 @@ void bdrv_append(BlockDriverState *bs_new, BlockDriverState
*bs_top)
tmp = *bs_new;
/* there are some fields that need to stay on the top layer: */
+ tmp.open_flags = bs_top->open_flags;
/* dev info */
tmp.dev_ops = bs_top->dev_ops;
--
1.7.9.3
- [Qemu-devel] [PATCH 24/26] stream: tweak usage of bdrv_co_is_allocated, (continued)
- [Qemu-devel] [PATCH 24/26] stream: tweak usage of bdrv_co_is_allocated, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 16/26] qemu-io: correctly print non-integer values as decimals, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 25/26] stream: move is_allocated_above to block.c, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 17/26] qemu-io: fix the alloc command, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 15/26] qemu-iotests: strip spaces from qemu-img/qemu-io/qemu command lines, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 21/26] stream: fix ratelimiting corner case, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 18/26] stream: fix sectors not allocated test, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 19/26] stream: add testcase for partial streaming, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 26/26] stream: move rate limiting to a separate header file, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 20/26] stream: pass new base image format to bdrv_change_backing_file, Paolo Bonzini, 2012/04/12
- [Qemu-devel] [PATCH 27/26] block: another bdrv_append fix,
Paolo Bonzini <=