qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] tci: GETPC() macro must return an uintptr_t


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] tci: GETPC() macro must return an uintptr_t
Date: Tue, 17 Apr 2012 11:27:24 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 04/17/2012 11:22 AM, Stefan Weil wrote:
> Change the data type of tci_tb_ptr, so GETPC() returns an
> uintptr_t now (like for all other TCG targets).
> 
> This completes commit 2050396801ca0c8359364d61eaadece951006057
> and fixes builds with TCI.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  exec-all.h |    2 +-
>  tci.c      |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/exec-all.h b/exec-all.h
> index a963fd4..585d44f 100644
> --- a/exec-all.h
> +++ b/exec-all.h
> @@ -283,7 +283,7 @@ extern int tb_invalidated_flag;
>  /* Alpha and SH4 user mode emulations and Softmmu call GETPC().
>     For all others, GETPC remains undefined (which makes TCI a little faster. 
> */
>  # if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4)
> -extern void *tci_tb_ptr;
> +extern uintptr_t tci_tb_ptr;
>  #  define GETPC() tci_tb_ptr

Nice way to side-step the entire () in macro issue :)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]