qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argu


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list
Date: Tue, 17 Apr 2012 22:26:55 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

Il 17/04/2012 21:36, Luiz Capitulino ha scritto:
> +            switch(qobject_type(obj)) {
> +            case QTYPE_QSTRING:
> +                qstring_append(arglist,
> +                               qstring_get_str(qobject_to_qstring(obj)));
> +                break;

Does this escape commas correctly?

It seems much easier to use no_gen and qemu_opts_from_qdict...  Then
cmd_netdev_add can be

  void cmd_foo(QemuOpts *arglist, Error **errp);

and later on we could even replace the QemuOpts with a visitor for full
QAPI-ness...

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]