qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property fo


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property for X86CPU
Date: Wed, 18 Apr 2012 01:26:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0

Am 18.04.2012 01:11, schrieb Andreas Färber:
> Using it now would incur converting the three x86_def_t vendor words
> into a string for object_property_set_str(), then back to three words
> in the "vendor" setter.
> The built-in CPU definitions use numeric preprocessor defines to
> initialize the three words in a charset-safe way, so do not change the
> fields to char[48] just to use the setter.

Er, should've been char[12] - fixed on qom-cpu-x86 branch.

/-F

> 
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  target-i386/cpu.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 44 insertions(+), 0 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]