Re: [Qemu-devel] [PATCH 6/7 V6] Packet abstraction used by VMWARE network devices

[Michael S. Tsirkin]

On Tue, Apr 17, 2012 at 03:32:40PM +0300, Dmitry Fleytman wrote:
> +/*=============================================================================
> + 
> *=============================================================================
> + *
> + *                            TX INTERFACE
> + *
> + 
> *=============================================================================
> + 
> *===========================================================================*/
> +
> +/* tx module context handle */
> +typedef void *VmxnetTxPktH;

This gets you zero type safety and makes debugging impossible.
Just use pointers like everyone does.

-- 
MST