Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

[Andreas Färber]

Am 18.04.2012 14:09, schrieb Anthony Liguori:
> On 04/18/2012 03:36 AM, Peter Maydell wrote:
>> On 17 April 2012 22:33, Anthony Liguori<address@hidden>  wrote:
>>> Kernel loading is a hack.  I'll go out on a limb and say that most
>>> non-x86
>>> boards are doing it completely wrong.  Messing around with CPU state
>>> has no
>>> business in machine init.  It creates horrible dependencies about RAM
>>> initialization order and problems for reset/live migration.
>>>
>>> The kernel should be presented as a virtual device (an emulated flash or
>>> whatever) and there should be firmware that loads the kernel
>>> appropriately.
>>> Then we wouldn't need changes like this in the first place.
>>
>> Yeah, I tend to agree that that would be a cleaner approach, but so far
>> it hasn't been a requirement. Feel free to submit patches to fix kernel
>> loading for these boards if you want to be able to rely on this
>> behaviour :-)
> 
> Well hopefully now we can agree that what Blue had to do with qtest
> isn't so bad :-)

What I find bad here is that this is a touch-all patch that's touching
multiple targets and lots of ARM boards at once (and that I'm not seeing
what 3/3 this might be good for). I'd suggest to break it down, then I
can integrate most of the target-* pieces into my pending QOM'ification
series with which this collides in cpu_*_init(). In the area of ARM we
don't strictly need to make all boards qtest'able at once, so Peter
could defer the decision to Calxeda and Samsung or some new ARM
bootloader framework if he sees the need, as maintainer.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg