Re: [Qemu-devel] [PATCH 13/36] vmstate: port ppc cpu

[Alexander Graf]

On 11.04.2012, at 13:56, Andreas Färber wrote:

> Am 19.03.2012 23:57, schrieb Juan Quintela:
>> Added sdr1_vmstate because storing the value requires calling 
>> ppc_store_sdr1().
>> The position when the function is called also changes (I think it is save).
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> target-ppc/cpu.h     |    5 +-
>> target-ppc/machine.c |  245 
>> ++++++++++++++++++--------------------------------
>> 2 files changed, 90 insertions(+), 160 deletions(-)
> 
> I do not feel comfortable ack'ing this change, and there's CCs missing.
> 
> David or Scott, are you familiar with this part of code? Otherwise we'll
> need to defer it to next week when Alex is back. Series seems fairly
> self-contained, so the Soft Freeze shouldn't be a problem.
> 
> Note that this slightly conflicts with CPU QOM'ification, where the goal
> is to move fields out of CPUPPCState and into PowerPCCPU. But that could
> be adjusted in a follow-up. Probably applies to other patches in the
> series, too.

I don't think live migration is working properly on ppc atm anyways, so I'm 
fine with whatever changes you do here really. If it breaks, we'll have to fix 
it throughout anyways.


Alex