[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 09/10] Add set_cachesize command
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH v9 09/10] Add set_cachesize command |
Date: |
Thu, 19 Apr 2012 10:11:45 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/18/2012 08:37 PM, Anthony Liguori wrote:
> On 04/11/2012 01:49 PM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Orit Wasserman<address@hidden>
>> Signed-off-by: Benoit Hudzia<address@hidden>
>> Signed-off-by: Petter Svard<address@hidden>
>> Signed-off-by: Aidan Shribman<address@hidden>
>> ---
>> arch_init.c | 5 +++++
>> hmp-commands.hx | 15 +++++++++++++++
>> hmp.c | 13 +++++++++++++
>> hmp.h | 1 +
>> migration.c | 31 ++++++++++++++++++++++++++++++-
>> migration.h | 2 ++
>> qapi-schema.json | 13 +++++++++++++
>> qmp-commands.hx | 22 ++++++++++++++++++++++
>> 8 files changed, 101 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch_init.c b/arch_init.c
>> index 793f0be..af9fcc3 100644
>> --- a/arch_init.c
>> +++ b/arch_init.c
>> @@ -175,6 +175,11 @@ typedef struct __attribute__((packed)) XBZRLEHeader {
>>
>> static uint8 *prev_cache_page;
>>
>> +void xbzrle_cache_resize(int64_t new_size)
>> +{
>> + cache_resize(new_size);
>> +}
>
> If it needs to be a power of 2, then take an integer order instead of a byte.
> That makes the function impossible to misuse.
That is a good idea.
>
> Regards,
>
> Anthony Liguori
- Re: [Qemu-devel] [PATCH v9 08/10] Add migration capabilites, (continued)