[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid f
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb-ehci: Ensure frindex writes leave a valid frindex value |
|
Date: |
Thu, 19 Apr 2012 14:14:58 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120307 Thunderbird/10.0.3 |
On 04/03/12 14:21, Hans de Goede wrote:
> frindex is a 14 bits counter, so bits 31-14 should always be 0, and
> after the commit titled "usb-ehci: frindex always is a 14 bits counter"
> we rely on frindex always being a multiple of 8. I've not seen this in
> practice, but theoretically a guest can write a value >= 0x4000 or a value
> which is not a multiple of 8 value to frindex, this patch ensures that
> things will still work when that happens.
Patch added to usb patch queue.
thanks,
Gerd